Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move client capabilities to features #738

Merged
merged 2 commits into from
Dec 31, 2021

Conversation

krassowski
Copy link
Member

References

This is a pre-requisite of #76 step 3, and enables third-party extensions to register the client capabilities they provide with the server (which is essential for some servers to return relevant responses).

Code changes

  • adds optional capabilities?: ClientCapabilities to IFeature public interface
  • surfaces the capabilities from connection through connection_manager up to adapter
  • in adapter the capabilities of active features are merged

User-facing changes

  • For servers which optimize responses/work based on client capabilities the performance might be slightly increased when specific features are disabled

Backwards-incompatible changes

None

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jupyter-lsp/jupyterlab-lsp/client-capability-to-features

@krassowski krassowski enabled auto-merge December 31, 2021 11:46
@krassowski krassowski merged commit 5d33fd2 into master Dec 31, 2021
@krassowski krassowski deleted the client-capability-to-features branch December 31, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant